This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/cache busting #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch appends content hashes to the file names of compiled scripts and styles to support cache busting. The mapping between original file names (e.g. `app.js`) and built file names (e.g. `app-c46010.js`) is stored in `rev-manifest.json`; the app reads the manifest file to insert the most recent asset URLs into the HTML. When running in debug mode, the app will restart whenever `rev-manifest.json` changes, so that the developer always sees the most recent versions of the built assets. All commands in `package.json` work as before; use `npm run watch-all` for local development. [Resolves fecgov#672]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch appends content hashes to the file names of compiled scripts
and styles to support cache busting. The mapping between original file
names (e.g.
app.js) and built file names (e.g.app-c46010.js) isstored in
rev-manifest.json; the app reads the manifest file to insertthe most recent asset URLs into the HTML. When running in debug mode,
the app will restart whenever
rev-manifest.jsonchanges, so that thedeveloper always sees the most recent versions of the built assets.
All commands in
package.jsonwork as before; usenpm run watch-allfor local development.
NB: The related issue isn't part of the current sprint, but I needed something to do with my Saturday afternoon 😃. More seriously, I think this is an important fix to get out before the site gets into users' hands--without it, any changes to the javascript or css that we make after users load the app will potentially break their experience until they clear their browser cache.
[Resolves #672]