Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

URL formatting #13

Merged
merged 3 commits into from
Dec 29, 2014
Merged

URL formatting #13

merged 3 commits into from
Dec 29, 2014

Conversation

theresaanna
Copy link
Contributor

This pull request:

  • gives single committee and candidate pages a URL like "http://localhost/committee/id"
  • moves single-links.js functionality (links in results tables to single entity pages) into tables.js
  • moves id out of filters in the event context object and into a root-level property
  • renames cmte_id and candidate_id to id
  • makes all URLs absolute so that they resolve properly (note that many are absolute per the Node app's static asset handling. ex. /static/img -> /img)
  • removes the Chosen binding from the single entity templates and puts it in single-entity.js
  • adds a 'bind:singleEntity' event to init Chosen on single entity pages
  • moves url updating from load:singleEntity -> render:singleEntity in the event that there are data loading issues (you'd never get to the single entity page if there are)
  • moves the tablist.js module to the vendor dir

noahmanger pushed a commit that referenced this pull request Dec 29, 2014
@noahmanger noahmanger merged commit d83195e into master Dec 29, 2014
@theresaanna theresaanna deleted the single-page-urls branch February 9, 2015 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants