This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Fix errors on committee profile pages #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed rows that were not producing real data - fixed spelling errors - Expanded the explanation when no data is shown
jmcarp
added a commit
that referenced
this pull request
May 6, 2015
Fix errors on committee profile pages
| <h3 class="section-header">Detailed Summary</h3> | ||
| {% with committee=context() %} | ||
|
|
||
| {% set table_data = [ | ||
| (committee.totals.0.individual_itemized_contributions, 'Itemized Individual Contributions'), | ||
| (committee.totals.0.individual_unitemized_contributions, 'Unitemized Individual Contributions'), | ||
| (committee.totals.0.transfers_to_affiliated_committee, 'Transfer from a Committee'), | ||
| (committee.totals.0.transfers_to_affiliated_committee, 'Transfer to a Committee'), |
There was a problem hiding this comment.
Shouldn't this field go under disbursements, rather than income? (Actually, it is duplicated in the table now.)
In the nesting refactor branch I changed this to transfers_from_other_authorized_committee, but we need to find an appropriate analogous field to pull from the PacOrParty data for this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#695