This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Restore glossary search on typeahead select. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user selects an option in the glossary typeahead, the associated text should appear below. A previous bug fix prevented this behavior, such that selecting an option did not show the glossary text.
|
I totally just did this randomly here 09664f3 . Happy to go with either method. But we'll want to update this line here: https://github.com/jmcarp/openFEC-web-app/blob/feature/fix-glossary-typeahead/static/js/modules/typeahead.js#L187 |
|
I like you're approach. Can you just change the main typeahead to be bound to the correct search bar and remove the |
…/fix-glossary-typeahead
|
Updated the PR @noahmanger. I moved both |
noahmanger
pushed a commit
that referenced
this pull request
May 7, 2015
Restore glossary search on typeahead select.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user selects an option in the glossary typeahead, the
associated text should appear below. A previous bug fix prevented this
behavior, such that selecting an option did not show the glossary text.
This also uses the
typeahead:selectedcustom event, which will hopefully be more robust and easier to understand than listening for particular keypress buttons. @msecret could you verify that the bug you fixed in d013e08 is still fixed with this patch? I think it is, but I'm not sure exactly how the glossary was behaving before you fixed it.