Feature/432 search #165
Feature/432 search #165
Conversation
This uses a fake def on the backend to get a candidate/committee with one opposite type nested in it. TODO: - Rename nested type to "primary" - Finish template side
I'm using a new html class prefix for selenium tests, "tst". I thought about this concept at my last job, am not sure about it and how useful it will be. Essentially, I just don't want tests breaking because of hooks failing from the HTML. I'm hoping seeing a class like this as a dev will ensure you look at the tests when you change the hook.
Conflicts: __init__.py
TODO: - Style green bar - Merge template so it can be used for committees - Figure out time periods
TODO: - Style green box. - Logic for the timelines and currently active. - Responsive check.
Fixed up a few other things as well.
I tried to abstract away the module a bit to allow for resuability.
TODO: - The search filter interface - Switch out the side panels for committees page.
|
Looking good. Here's some things though (on a candidate search for obama):
|
|
Oh, and also the searchbar in the header needs the type dropdown. |
|
Also, is there currently a limit on the search results? I'd like to try it with no limit. |
|
@jmcarp can you look into Noah's comment "The associated committees aren't right. They should be the Principal Campaign Committee for each. There's a bunch that aren't even authorized"? I'm currently using the new search API route for the nested committee. Was that change not pushed to all envs? |
|
@msecret checking that out now. Do you have an example of a committee that's wrong? |
|
@msecret have you had a chance to fix the things I noted above? Doesn't look like it yet or maybe I'm just out of date. |
Conflicts: __init__.py openfecwebapp/api_caller.py static/styles/_components/_search-bar.scss templates/search-results.html
As defined by Noah
This was done to ensure they UI matched the main search on the homepage and so users could search by candidate/committee on every page.
The new search results page doesn't have an h2 with the query as the old page did, so the tests were modified to just find a custom selector for the results. The "tst" html class prefix is being used specifically for tests.
|
- Hide header search bar on home page, as main search bar is already there. - Change committee link to search as thats what the text states. - No limit on api call as its important for users to be able to see everything when searching, as some reported not being able to find what they were looking for. - Pass search term as q so it works with existing setup and code. - Removed test for header search on landing page as it was removed.
- Appending a message to top and bottom of search results when more then 20 results (the current max for api) so the user knows they're not seeing all results and can click a link to view more. - Updating the top search bar to have the query input and the type selected so the user knows the current search.
|
What the to many results UI looks like, @noahmanger you'll probably want to make modifications
|
|
Perfect. Yeah I can work with that On Wed, May 27, 2015 at 4:04 PM, Marco Segreto notifications@github.com
Noah Manger |
Just the `<div>` containing the elements is in the partial. It will still need to be wrapped in a form.
Feature/search styling
…pp into feature/432-search
This was due to broken selenium test because the id of an element changed and was moved to a class.
Work in progress
Check commit message for more info