This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/committee dates noah #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it correct it needs to be calculated from cycle instead of year.
so it would be "reports filed 2007-2008" but when I tried
{{ cycle - 1 }} - {{ cycle }}
It couldn't do the math. So I am removing the wrong label and leaving a note.
…/committee-dates-noah
Using prototypal inheritance.
New filter necessary to get the last three characters from the beginning_image_number to build the url
Conflicts: __init__.py templates/committees-single.html
- adapting date formating to new style
- getting rid of extra {% with committee=context() %}
- made formatting clearer on recent reports
…-web-app into feature/committee-dates-noah
…/committee-dates-clean
(We still need to go over what fields we are showing)
…/committee-dates-noah
| assert app.date_filter_md(None) == '' | ||
|
|
||
|
|
||
| def test_last_n_characters(): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to do clean up locally accidentally deleted the origin branch, thus closing the last PR.
Apologies for this becoming the pull request from 🔥
The last few commits respond to the comments @jmcarp and @msecret made on the last one:
last_n_charactersfilterjQuerywith$