Feature/fix typeahead sort #178
Conversation
The actual issue here turned out to be that we were checking the candidate and committee IDs against `null` but were getting back a different falsy value of `''`. This patch uses a more general check, ignoring results with all falsy ID values, and revises the filtering logic to use a more explicit filter and map, rather than the implicit filtering in `$.map`. [Resolves https://github.com/18F/openFEC/issues/741]
| @@ -10,6 +11,10 @@ | |||
|
|
|||
| from openfecwebapp.sauce import SauceClient | |||
|
|
|||
| # Silence Selenium logs | |||
| remote_logger = logging.getLogger('selenium.webdriver.remote.remote_connection') | |||
| remote_logger.setLevel(logging.WARN) | |||
There was a problem hiding this comment.
Nice. Does this mean we'll just see warnings and failures?
There was a problem hiding this comment.
For this logger, we'll only see messaged logged at WARN, ERROR, or CRITICAL. All other loggers are unaffected.
|
By the way, in the spirit of disclosure, I now realize that I broke this in the first place on the API side. We're currently using the latest stable version of marshmallow for serialization, and null values are serialized as empty strings. I actually brought this up with the marshmallow developer a few weeks ago, and he fixed that behavior such that nulls serialize to nulls, but I didn't notice that we needed to upgrade to the dev version of marshmallow to get this change. I'll do that later today. Shorter version: sorry @noahmanger! |
|
No worries! Thanks for the transparency! On Thu, May 14, 2015 at 9:38 AM, Joshua Carp notifications@github.com
Noah Manger |
Fix grouping in main typeahead search.
The actual issue here turned out to be that we were checking the
candidate and committee IDs against
nullbut were getting back adifferent falsy value of
''. This patch uses a more general check,ignoring results with all falsy ID values, and revises the filtering
logic to use a more explicit filter and map, rather than the implicit
filtering in
$.map.[Resolves https://github.com/18F/openFEC/issues/741]