This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Candidate improvements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
January 2, 2015 18:39
And saving a separate file with the other stuff for later
|
|
||
| if (typeof results[i].elections[0].affiliated_committees !== 'undefined') { | ||
| var committeesAll = [], | ||
| committeesA = [], |
There was a problem hiding this comment.
Totally a style thing, but I'd be in favor of switching these three arrays to more descriptive names, even if long. I think it reads a bit clearer that way. committeesAuthorized or authorizedCommittees and so on in that pattern works, I think. I also think its ok to abstract away some of the API's mappings here.
|
This looks great. The two things I commented on are teensy tiny. Really fantastic work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mega PR but don't be initmidated. This contains:
Probably only need eyes on the first two bullet points, but feel free to read through the style updates.