This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Add blue-green deploys. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code borrowed from API.
|
Important: this deploy uses two applications, "web-a" and "web-b". Environment variables must be set for these new apps in order for them to work--otherwise, we'll get errors. @arowla let's talk about how to proceed before deploying. |
|
Let's set up the user-provided service. I've seen enough of hand-set ENV vars disappearing already, even without this change. |
|
See 18F/openFEC#796 |
| NEW_RELIC_APP_NAME: OpenFEC Web (production) | ||
| FEC_WEB_API_URL: https://api.open.fec.gov/ | ||
| FEC_FORCE_HTTPS: true | ||
| # These must be set manually via `cf set-env` |
There was a problem hiding this comment.
Would it make sense to note somewhere (or just right here) all the additional varnames we now need to make sure are manually set on the creds service?
# FEC_WEB_API_KEY
# FEC_WEB_API_KEY_PUBLIC
# NEW_RELIC_LICENSE_KEY
... And any others I might have missed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code borrowed from API.