This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/better bar labels #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to check: did you look at this on different device sizes like mobile and tablet? I'm worried about the width of them labels now. |
|
Yep. They break to two lines on smaller screens. Things will get tricky once we have more than 4 groups, but we're ok for now. |
|
Oops. Didn't update the tests...working on that now. |
added 2 commits
May 26, 2015 17:08
Changing the tests to expect a day in the displayed date
Should been 15 not 2015
|
LGTM |
LindsayYoung
added a commit
that referenced
this pull request
May 27, 2015
Feature/better bar labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the dates on the bar chart labels to be
dd/mm/yyto address https://github.com/18F/openFEC/issues/821 . They make so much more sense now.Also restyled the typeahead suggestions to make names easier to read (addresses https://github.com/18F/openFEC/issues/833)