This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Generate correct history parameter when next cycle is not available. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the `next_cycle` filter to generate the `history` query parameter for the candidate detail page. The filter is meant to get the next active cycle greater or equal to the specified cycle. This patch handles the edge case in which no such cycle is found, in which case we should simply use the latest active cycle. This fixes some errors on Jeff Flake's candidate page.
|
👍 |
|
Now 2017-2018 is showing up in the election cycle picker, can we add a filter for that in this function too? |
|
@LindsayYoung the 2017-2018 cycle shouldn't be showing up anymore with this patch. At least I don't see it anymore. Let me know if you're still seeing this. |
|
LGTM will merge when tests pass |
LindsayYoung
added a commit
that referenced
this pull request
May 28, 2015
Generate correct history parameter when next cycle is not available.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
next_cyclefilter to generate thehistoryquery parameterfor the candidate detail page. The filter is meant to get the next
active cycle greater or equal to the specified cycle. This patch handles
the edge case in which no such cycle is found, in which case we should
simply use the latest active cycle. This fixes some errors on Jeff
Flake's candidate page.