Moving to Flask

[theresaanna]

Sorry, this is a giant one.

Removing almost all of the client side app. Leaving behind pieces that deal with filter formatting and activation, and Typeahead. (Which works, btw. The back end just times out sometimes, presumably because certain requests take too long. I imagine "Obama" and "Romney" like we're all trying have a bazillion committees to pull totals for. Try "pelosi" and choose Nancy Pelosi and her first committee.)

I've only successfully written tests for the openfecwebapp.data_mappings module. Maybe I'm just tired and have been working too long, but I can't quite figure out how to test the views and api_caller modules without headaches. I am happily taking suggestions.

I really want to remove the load_totals calls from openfecwebapp.views.render_page but am not sure what is best. Again, would like feedback.

Also includes some of @noahmanger's markup and css work.

The JS version is frozen in https://github.com/18F/openFEC-web-app/tree/js-version.

[cmc333333]

Might be easier to read if you iterate over the elements rather than the index:

for cmte in candidate['affiliated_committees']:

[cmc333333]

It's amazing how easy you make porting this over seem, @theresaanna . If you all want to keep mustache/handlebar/etc. templates, you can; you'll just need to find the Python library that implements them instead of using jinja.

I made a bunch of style comments, but they are all about tightening things up. In general, try to add docstrings to your functions rather than # comments. Also, remember that you can iterate over the elements of a collection rather than the index. If you really need the index, you can

for idx, value in enumerate(your_list)

[theresaanna]

@cmc333333 I looked at the available Flask + Handlebars libraries and they were sparse. I know I could use the regular Python Handlebars library, but I wanted to keep things very clean and Flask, and I didn't want to put in the effort to figure it out, tbh. I think Jinja is nice, and I'm glad to have the concept of template blocks now.

Thank you for your review. I suspected many things could be more pythonic, so this is great feedback.