This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Summary charts should not display chart for None #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no information for a candidate/committee, the user won't want to see any chart bar which confirms a lack of information.
noahmanger
pushed a commit
that referenced
this pull request
Jun 3, 2015
…ng_with_none Summary charts should not display chart for None
jmcarp
added a commit
to jmcarp/openFEC-web-app
that referenced
this pull request
Jun 12, 2015
* Hide bars with null value. * Hide series with all null values. * Hide group series with all null series. This is a follow up on https://github.com/18F/openFEC/issues/896, which was partially resolved by fecgov#229.
jmcarp
added a commit
to jmcarp/openFEC-web-app
that referenced
this pull request
Jun 12, 2015
* Hide bars with null value. * Hide series with all null values. * Hide group series with all null series. This is a follow up on https://github.com/18F/openFEC/issues/896, which was partially resolved by fecgov#229.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no information for a candidate/committee, the user won't
want to see any chart bar which confirms a lack of information.