This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/glossary improvements #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All terms are visible, with definitions collapsed
|
Oh, and the tests need to be updated. Would love a quick lesson on these so I can get better at maintining them. |
| "term":"Candidate", | ||
| "definition":"An individual seeking nomination for election, or election, to a federal office becomes a candidate when he or she (or agents working on his or her behalf) raises contributions or makes expenditures that exceed $5,000." | ||
| "glossary-term":"Candidate", | ||
| "glossary-definition":"An individual seeking nomination for election, or election, to a federal office becomes a candidate when he or she (or agents working on his or her behalf) raises contributions or makes expenditures that exceed $5,000." |
There was a problem hiding this comment.
This description still doesn't make sense.
Feature/glossary improvements
…/glossary-improvements
added 2 commits
June 4, 2015 09:28
Feature/glossary improvements
…/glossary-improvements
LindsayYoung
added a commit
that referenced
this pull request
Jun 5, 2015
Feature/glossary improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces Typeahead in the glossary with ListJS for search/filtering.
It's almost there, but needs some finessing. The way it does search right now is to search through both the terms and definitions for any instance of the word, which means that search results can be a little confusing:
Also, when you click on a term, like "committee" it just runs a search for that term, returning multiple results.
Would be nice if someone could take a look and make any modifications.