This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/glossary improvements #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People want to see the various parts of the report at the same time so not collapsing the other accordion items when you open a new one is better.
Users of the accordion plugin might want to configure it so it closes the various items when you open a new one.
Feature/flexbox fix
When a user sees a chart for a negative value, they should see a bar chart of zero. TODO: A better implementation of this would be to actually show a negative value through a different kind of chart or a different color, but this requires design consideration.
…g_accordion Feature/897 stop collapsing accordion
…th_negatives Ensures charts properly deal with negative values
…/glossary-improvements
|
Great! Those changes def help. I'm really not sure if it's better to just search the term or also the definition. How much work do you think that'd take? Also, I'm pretty slammed today so if you're able to just update the tests that'd be great. I'll look at what you do and ask any questions. |
noahmanger
pushed a commit
that referenced
this pull request
Jun 3, 2015
Feature/glossary improvements
|
@noahmanger I'll update the tests and look into modifying the search today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few proposed changes to the new glossary:
@noahmanger: I'm happy to update the tests and/or talk through how they work. I can also work on filtering items by title and not by contents (agreed that this is potentially confusing) if you think that's the correct behavior.