This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/glossary improvements #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmcarp
commented
Jun 3, 2015
jmcarp
commented
- Only search on glossary term names
- Fix selenium tests
When there is no information for a candidate/committee, the user won't want to see any chart bar which confirms a lack of information.
When a candidate has multiple authorized or principal committees, users should see aggregated receipts, cash on hand, etc., across all such committees before the details for each committee. This patch shows these aggregate on the candidate detail page, but only when the candidate has multiple authorized committees. [Resolves fecgov#832]
Due to a typo in the committee detail template, addresses are currently hidden for committees that are not associated with a candidate. This patch moves the relevant `endif` to the right place. h/t @andrewmaier
Always show committee address.
…_dealing_with_none Summary charts should not display chart for None
Feature/consolidate search
…-financials Aggregate committee financials for multiple authorized committees.
Feature/none definition
…/glossary-improvements
|
Tests are failing, but UI-wise it works for me great. |
noahmanger
pushed a commit
that referenced
this pull request
Jun 4, 2015
Feature/glossary improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.