Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Handle null values in all charts. #267

Merged
merged 1 commit into from
Jun 12, 2015

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jun 12, 2015

  • Hide bars with null value.
  • Hide series with all null values.
  • Hide group series with all null series.

This is a follow up on https://github.com/18F/openFEC/issues/896, which
was partially resolved by #229.

* Hide bars with null value.
* Hide series with all null values.
* Hide group series with all null series.

This is a follow up on https://github.com/18F/openFEC/issues/896, which
was partially resolved by fecgov#229.
@jmcarp
Copy link
Contributor Author

jmcarp commented Jun 12, 2015

See /committee/C00005462?cycle=1980 before and after the patch. Before:
screen shot 2015-06-12 at 12 54 39 pm

After:
screen shot 2015-06-12 at 12 55 32 pm

In this case, the entire "Cash and Debt" chart is hidden, since all the values are null. But the patch is a little more nuanced than that--it will also hide pairs of bars that are all null, as well as individual null bars.

msecret pushed a commit that referenced this pull request Jun 12, 2015
@msecret msecret merged commit 8373db7 into fecgov:develop Jun 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants