Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Creating dropdowns with list of checkboxes #270

Merged
merged 24 commits into from
Jun 19, 2015

Conversation

noahmanger
Copy link
Contributor

This is a work in progress, but wanted to show what I'm working on for the UI at least.

Begin with a dropdown button:

screen shot 2015-06-15 at 2 29 18 pm

When you click, a list of checkboxes appears:

screen shot 2015-06-15 at 2 29 28 pm

The list is limited to a certain height, but you scroll within it. Click on the button again to hide the list.

One thing I'm not certain about is how to signify if there are filters selected. Do you change the text on the button to say which filters are selected? Change it to be generic like "2 filters selected", or just show a different color or something? Ideas? @jenniferthibault ?

Also, @jmcarp take a look at the code and let me know if that makes sense. I was thinking that it's probably best to wrap each thing in a <fieldset> with the name set to the appropriate filter.

@jenniferthibault
Copy link
Contributor

@noahmanger what about something like this? Where the applied filters are listed below the dropdown as they're checked, and can be x'ed out of:
artboard 1 copy

@noahmanger
Copy link
Contributor Author

@jenniferthibault I really like the idea of showing the "filters applied" as removable tags like that. Two questions:

  1. I think it still leaves the question of what the behavior is in the select dropdown. Is it still a list of checkboxes? Can you check multiple without the menu closing or only one?
  2. What do you think about displaying the tags in the box above the table, maybe in place of the "hide filters" button (which could be relocated). I was noodling on this idea because it would make the filters visible even when closed, which would really help on smaller screens. But maybe having them visually separated from the actual filter controls would be confusing?

@noahmanger
Copy link
Contributor Author

So I'm playing around with this pattern where the dropdown contains all additional options, but selecting one moves it above, that way you can easily see all applied filters:

multiselect

It also allows us to choose to force certain common filters to always be visible, even when not checked (i'm thinking like the common party choices) while hiding the rest. Thoughts?

@noahmanger
Copy link
Contributor Author

Totally rabbit-holed on this one, but I like how it's shaping up:

screen shot 2015-06-17 at 8 09 25 pm

@LindsayYoung
Copy link
Contributor

I like this. Will merge when tests pass.

LindsayYoung added a commit that referenced this pull request Jun 19, 2015
Creating dropdowns with list of checkboxes
@LindsayYoung LindsayYoung merged commit 557a6eb into develop Jun 19, 2015
@noahmanger noahmanger deleted the feature/improved-filters branch August 3, 2015 22:49
@noahmanger noahmanger restored the feature/improved-filters branch August 3, 2015 22:49
@noahmanger noahmanger deleted the feature/improved-filters branch August 3, 2015 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants