This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Creating dropdowns with list of checkboxes #270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@noahmanger what about something like this? Where the applied filters are listed below the dropdown as they're checked, and can be x'ed out of: |
@jenniferthibault I really like the idea of showing the "filters applied" as removable tags like that. Two questions:
|
Restore filter functionality.
So I'm playing around with this pattern where the dropdown contains all additional options, but selecting one moves it above, that way you can easily see all applied filters: It also allows us to choose to force certain common filters to always be visible, even when not checked (i'm thinking like the common party choices) while hiding the rest. Thoughts? |
Fix keypress and focus behavior on checkboxes.
Fix checkbox keypress toggling adjacent dropdowns.
I like this. Will merge when tests pass. |
LindsayYoung
added a commit
that referenced
this pull request
Jun 19, 2015
Creating dropdowns with list of checkboxes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, but wanted to show what I'm working on for the UI at least.
Begin with a dropdown button:
When you click, a list of checkboxes appears:
The list is limited to a certain height, but you scroll within it. Click on the button again to hide the list.
One thing I'm not certain about is how to signify if there are filters selected. Do you change the text on the button to say which filters are selected? Change it to be generic like "2 filters selected", or just show a different color or something? Ideas? @jenniferthibault ?
Also, @jmcarp take a look at the code and let me know if that makes sense. I was thinking that it's probably best to wrap each thing in a
<fieldset>
with the name set to the appropriate filter.