This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Fixing candidate pages #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed border Fixed no-wrap cells
`npm install --save tablesort`
Adding side bar + expand button
Restyling
add tablesort to dependencies
| @@ -94,6 +94,9 @@ def map_totals(t): | |||
| from the 'totals' endpoint for use on candidat | |||
| and committee pages | |||
| """ | |||
| if not t['results'][0].get('reports') and not t['results'][0].get('totals'): | |||
Conflicts: templates/candidates-single.html
…ing-candidate-pages
|
👍 Python stuff at the top -- there's a lot of diff associated with the merges, though |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request primarily fixes candidate pages. As of now, they are not rendering properly when using the api_performance branches.
It also incorporates some rework of render_page, which made sense in the context of some of this work.
I am under no illusions that these are the most elegant solutions ever. These are patches so that people can use the candidate page. I figure that things are going to change a lot once the API work is done, so I am not fretting the solutions for the moment.
Right now, totals data for committees that are not primary aren't showing. I thought, since these pages are broken, I'd get this in regardless. Unsure if its an API issue, front end issue or both.