This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/contributions tab improvements #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of smaller and more frequent PRs, here's some more styling work on the contributions tab. Jen and I talked and realized that because the Size and State comparisons were simply different views on the same data shown in the toggle-able section at the bottom, it made sense to have them all set as panels like so:
This also parallels the behavior on the election page as well as on the disbursements panel.
One thing we may want to do as a result of this is moving the Size comparison table to the same standard datatable we use for the others.