Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Feature/election pages #357

Merged
merged 38 commits into from
Aug 5, 2015
Merged

Feature/election pages #357

merged 38 commits into from
Aug 5, 2015

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Jul 23, 2015

Add a base election page and the first widget from the designs: a table of candidates in the race with their current financials. URLs for election pages look like this: /elections?office=senate&state=NY&cycle=2014. Thoughts @noahmanger @LindsayYoung?

Note: this is branched off #327.

@noahmanger
Copy link
Contributor

Minor thing, but I think it would be better if the URL format was closer to
the way we're building them for candidates and committees, so like:

/elections/ny/senate?cycle=2014

On Thu, Jul 23, 2015 at 10:01 AM, Joshua Carp notifications@github.com
wrote:

Add a base election page and the first widget from the designs: a table of
candidates in the race with their current financials. URLs for election
pages look like this: /elections?office=senate&state=NY&cycle=2014.
Thoughts @noahmanger https://github.com/noahmanger @LindsayYoung
https://github.com/LindsayYoung?

Note: this is branched off #327

#327.

You can view, comment on, or merge this pull request online at:

#357
Commit Summary

  • Rough sketch of code splitting with factor-bundle.
  • Still rough, but it works.
  • Auto-merge revision hashes after bundle.
  • Remove deprecated clean library.
  • Add uglify, preprocessify to factor-bundle task.
  • Merge branch 'develop' of github.com:18f/openFEC-web-app into
    feature/code-splitting
  • Move table initialization to page scripts.
  • Initialize tables on ready.
  • Replace old build-js task.
  • Restore missing column.
  • Merge branch 'develop' of github.com:18f/openFEC-web-app into
    feature/code-splitting
  • Move filings table to separate page.
  • Move all tables to page files.
  • Update columns.
  • Add initial election page with table of candidates.

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#357.

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

@jmcarp
Copy link
Contributor Author

jmcarp commented Jul 23, 2015

How about something like this:
/elections/presidential
/elections/senate/ny
/elections/house/ny/02

@noahmanger
Copy link
Contributor

I like it. But probably:

/president instead of /presidential

On Thu, Jul 23, 2015 at 10:37 AM, Joshua Carp notifications@github.com
wrote:

How about something like this:
/elections/presidential
/elections/senate/ny
/elections/house/ny/02

—
Reply to this email directly or view it on GitHub
#357 (comment).

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

@jmcarp
Copy link
Contributor Author

jmcarp commented Jul 30, 2015

@noahmanger this isn't finished, but there's a chunk of work that can be independently reviewed, merged, and styled if you have time. This currently has the list of active candidates and their summaries, an interface to pick candidates for detail comparisons, and aggregates by state, contribution size, and contributor type:
screen shot 2015-07-30 at 5 40 28 pm

@noahmanger
Copy link
Contributor

Awesome. Yeah, let's review. What branch is it?

On Thu, Jul 30, 2015 at 2:41 PM, Joshua Carp notifications@github.com
wrote:

@noahmanger https://github.com/noahmanger this isn't finished, but
there's a chunk of work that can be independently reviewed, merged, and
styled if you have time. This currently has the list of active candidates
and their summaries, an interface to pick candidates for detail
comparisons, and aggregates by state, contribution size, and contributor
type:
[image: screen shot 2015-07-30 at 5 40 28 pm]
https://cloud.githubusercontent.com/assets/1633460/8995854/25c198ee-36e2-11e5-91b0-f9871a4dcdae.png

—
Reply to this email directly or view it on GitHub
#357 (comment).

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

@jmcarp
Copy link
Contributor Author

jmcarp commented Jul 30, 2015

Code is at jmcarp/feature/election-pages. Parts of this depend on https://github.com/18F/openFEC/pull/1087.

@noahmanger
Copy link
Contributor

Did you want to get this merged in? Or still WIP?

@jmcarp
Copy link
Contributor Author

jmcarp commented Aug 3, 2015

There's definitely work left to do here, but I wouldn't mind getting it merged and doing the rest of the work in separate pull requests.

@noahmanger
Copy link
Contributor

That gets my vote.

On Mon, Aug 3, 2015 at 11:06 AM, Joshua Carp notifications@github.com
wrote:

There's definitely work left to do here, but I wouldn't mind getting it
merged and doing the rest of the work in separate pull requests.

—
Reply to this email directly or view it on GitHub
#357 (comment).

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

@noahmanger
Copy link
Contributor

Do we want to merge this in?

@jmcarp
Copy link
Contributor Author

jmcarp commented Aug 4, 2015

Let's merge and make changes in separate PRs.

@noahmanger
Copy link
Contributor

I'm now not getting any data on election pages. I've tried with both a local server and the dev api. I'm seeing this error a lot (but not always):

https://fec-dev-api.18f.gov/v1/elections?cycle=2014&office=senate&state=ny&per_page=0 422 (status code 422)

@jmcarp
Copy link
Contributor Author

jmcarp commented Aug 5, 2015

Ah, was working against my local API server and forgot to push up some necessary changes. Just submitted that PR at https://github.com/18F/openFEC/pull/1104.

@jmcarp
Copy link
Contributor Author

jmcarp commented Aug 5, 2015

Merged the relevant API patch.

noahmanger pushed a commit that referenced this pull request Aug 5, 2015
Merge pull request #357 from jmcarp/feature/election-pages
10d4d3a 
Feature/election pages
@noahmanger noahmanger merged commit 10d4d3a into fecgov:develop Aug 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmcarp @noahmanger