Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Removing the search select in favor of radios #363

Merged
merged 3 commits into from
Jul 29, 2015
Merged

Conversation

noahmanger
Copy link
Contributor

This makes the radio buttons the only way to change the search type. Changing the search type now works as expected.

screenshot-01

Also, this hides the header search on the search results page, as well as changes the way you hide the header (now just set a variable on the template hide_header_search = true).

screen shot 2015-07-23 at 4 08 07 pm

(Wasn't sure the style for template variables like this, so can change to fit the convention.)

@msecret
Copy link
Contributor

msecret commented Jul 24, 2015

@noahmanger I'm ready to merge once the test pass or its confirmed that it's a testing issue not a code issue.

@noahmanger
Copy link
Contributor Author

Weird. Tests pass for me locally and the errors i'm seeing on Travis look unrelated to what this is doing.

@noahmanger
Copy link
Contributor Author

Ugh. I can't tell why these tests are still failing. Anyone have ideas?

@jmcarp
Copy link
Contributor

jmcarp commented Jul 29, 2015

These look like probabilistic failures that aren't related to your changes--the tests are also passing locally for me (most of the time). I need to find some time to figure out why some tests are failing sporadically, but for now, merging this.

@jmcarp jmcarp merged commit 252be2e into develop Jul 29, 2015
@jmcarp jmcarp removed the plz-review label Jul 29, 2015
@noahmanger noahmanger deleted the feature/search-toggle branch August 3, 2015 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants