Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Cycle select update #364

Merged
merged 5 commits into from
Jul 24, 2015
Merged

Cycle select update #364

merged 5 commits into from
Jul 24, 2015

Conversation

noahmanger
Copy link
Contributor

Based on #351, I wanted to come up with a better, more consistent place for the cycle select. So this patch does just that. @jenniferthibault can you review to make sure this captures what we discussed yesterday?

There are now cycle selects on any tab where you can control the cycle (so everything except "Filings"), and changing one changes them all.

screenshot-02
screen shot 2015-07-23 at 5 44 26 pm
screen shot 2015-07-23 at 5 44 33 pm

Also: I moved the logic on the Candidates and Committees page so that even if there's no records, you still see the "financial summary" section heading and explanatory text.

screen shot 2015-07-23 at 5 45 38 pm

To do: Once we have persistent tab URLs, you'll no longer be bumped to the first tab upon changing the select on the second or third tab.

@jenniferthibault
Copy link
Contributor

Yup! This looks like what we talked about to me!
One thing, and apologies if this is late in the game to bring it up, I'm not sure how much of a PITA it will be.

I'd like to be sure that any time we are showing a range of numbers or a range of dates, we use an en-dash without surrounding spaces to separate them instead of a hyphen. An en-dash is typed on a Mac by holding option+- and releasing. On Windows, it's Alt+ 0``1``5``1 and release. En dashes are used exclusively for date and numerical ranges.


Examples
Hyphen with spaces: 2012 - 2013, $100 - $500
En dash without spaces: 2012–2013, $100–$500

Noah Manger added 2 commits July 23, 2015 18:21
And a little tweak
msecret pushed a commit that referenced this pull request Jul 24, 2015
@msecret msecret merged commit cfacfaf into develop Jul 24, 2015
@noahmanger noahmanger deleted the cycle-select-update branch August 3, 2015 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants