This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #351, I wanted to come up with a better, more consistent place for the cycle select. So this patch does just that. @jenniferthibault can you review to make sure this captures what we discussed yesterday?
There are now cycle selects on any tab where you can control the cycle (so everything except "Filings"), and changing one changes them all.
Also: I moved the logic on the Candidates and Committees page so that even if there's no records, you still see the "financial summary" section heading and explanatory text.
To do: Once we have persistent tab URLs, you'll no longer be bumped to the first tab upon changing the select on the second or third tab.