This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
add --cached flag to cache API requests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great call. Thanks! This has been on my never-ending todo list. |
theresaanna
added a commit
that referenced
this pull request
Feb 19, 2015
add --cached flag to cache API requests
|
👍 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a
--cachedflag that enables caching of API calls, facilitating a much faster frontend development workflow. You can run it like so:I almost put the cache installation code in
__init__.py, but ended up moving it toapi_caller.pyso that all of the request-specific stuff lived there, which makes it simpler to modify how caching is enabled if we were to ever move away from usingrequestsfor some reason. Happy to entertain another way of doing this, or to useargparseinstead of just sniffingsys.argv.