Feature/filter fixes #387
Feature/filter fixes #387
Conversation
| padding: 0 1rem; | ||
| } | ||
|
|
||
| .accordion__item { |
There was a problem hiding this comment.
Is there any reason this wouldn't be put in accordion.scss. Putting it here makes it harder to find.
There was a problem hiding this comment.
Good catch. Moved to _side-panel.scss along with other modifications to the accordion components from being within .side-panel.
| </ul> | ||
| <div class="date-range-input"> | ||
| <label for="min_date">From</label> | ||
| <input type="text" id="min_date" name="min_date" data-inputmask="'alias': 'mm/dd/yyyy'"> |
There was a problem hiding this comment.
Is there code that uses this inputmask?
When doing research for the pattern library, we found traditional input mask code can be problematic for screen readers: https://www.filamentgroup.com/lab/politespace.html
If we're using a traditional input mask, I suggest a discussion with Bristow to check, I would be fine merging this before that happens though.
There was a problem hiding this comment.
Ah. Just saw that discussion. Yeah, we're currently using it, but I'll file an issue to investigate further.
This does a few things to clean up the filters:
I imagine the stuff I did to dates is going to conflict with #386, so let's merge that first and then I'll make the appropriate changes.