Feature/panel desktop #392
Conversation
This is the basics for the panel interface on above mobile. This opens a panel to the right side of the table at 50%. This might be hard to animate, we might want to look at that later. TODO: - Create arrow icon on right side of each row to open the panel. - Change close button and icon for this breakpoint. - Figure out panel correct heading. - Figure out panel indentation.
The headers are supposed to be smaller on larger screens. There was an indentation problem with the fields of the panel. This was due to them being a td under dataTable, which in turn uses an !important rule likely because it has to override dataTable's inline code. This all has to be fixed but would likely be a larger refactor, so am ignoring now with a shameful rule.
|
This is looking really good. Not sure if you're still working on it, but the only thing I see worth noting is that the active row should be highlighted. |
|
Yea I was still working on a few things like that. I also wanted to get the arrow on the rows done, move the close button on desktop. What the status of those "View original image" button? Is there an existing link for that? Also, for the perma-link, I'm guessing it will take about a day to implement that. Is it something I should do this next sprint, or are there other things that are more important? |
|
Yeah I'd say it'd be good to do that this sprint. The "original image" link should exist...it may need to be built using the image numbers. @LindsayYoung how are we doing this now? |
|
Regardless, I think we can merge this in whenever the active state is ready. |
| } | ||
|
|
||
| #datatable-modal .panel .panel__row { | ||
| // TODO this shit is broken. |
There was a problem hiding this comment.
Haha, I was supposed to go back to that and write a better comment, I'll do so now
Check commit messages for explanations