This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Use DataTables for contribution size table. #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| min_amount: info.limits[0], | ||
| max_amount: info.limits[1] | ||
| }); | ||
| anchor.setAttribute('href', tables.buildAggregateUrl(uri, row.cycle)); |
There was a problem hiding this comment.
I didn't specify this before, but this should be on the total column, not the size column, to keep it consistent with the others tables.
|
Looks good other than that comment and the merge conflicts. |
…/contribution-size-datatable
|
@noahmanger fixed. |
|
This works by and large, so I'll merge. But I caught at least one case where there's inconsistency: The ones from this page aren't working: http://localhost:3000/committee/C00413914?cycle=2016&tab=receipts |
|
It seems to be an issue with either the data or the filters rather than with this code. |
noahmanger
pushed a commit
that referenced
this pull request
Aug 5, 2015
Use DataTables for contribution size table.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Resolves #398]