This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
[WIP] Feature/election lookup #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarp
force-pushed
the
feature/election-lookup
branch
from
132b689
to
65542be
Compare
| @@ -117,3 +118,9 @@ gulp.task('build-js', function() { | |||
| .bundle() | |||
| .pipe(callback('static/js/common.js')); | |||
| }); | |||
|
|
|||
| gulp.task('test', function() { | |||
| return mochify('./tests/unit/**.js') | |||
There was a problem hiding this comment.
I was thinking we'd keep dir organization here mirrored with the actual js. SO in this case, we'd have tests/unit/modules or tests/unit/pages. What do you think of that?
There was a problem hiding this comment.
Agreed. I separated the election lookup logic into a resuable module (modules/election-lookup) and a page that imports and instantiates the module (pages/election-lookup), so the tests have moved to tests/unit/modules/election-lookup.
So when you change the zip input it clears the state and district filters, and vice versa.
|
Updated with style improvements from @noahmanger. Want to merge now for testing tomorrow? If not, I can deploy this branch directly to the dev server. |
noahmanger
pushed a commit
that referenced
this pull request
Aug 13, 2015
[WIP] Feature/election lookup
|
Looks great. Let me know when you push it up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype of #354.