Use local styles conditionally. #478
Conversation
jmcarp
commented
Aug 17, 2015
jmcarp
commented
- Use styles from local fec-style URL if specified
- Add a place for vendor styles
* Use styles from local fec-style URL if specified * Add a place for vendor styles
|
@noahmanger we should be able to start deleting a bunch of styles from |
| @@ -0,0 +1 @@ | |||
| @import "fec-style/scss/styles.scss"; | |||
There was a problem hiding this comment.
Why is this being done here rather the /static/styles/styles.scss.
Also, I'm getting confused when things are referencing the local styles or fec-style.
|
Great. Yeah we shouldn't need any of that. And no need to keep themify-icons or the datatables responsive styles |
|
So is this so we can conditionally include fec-styles? And then also have local styles to override? |
|
@noahmanger are you adding datatables to fec-style? |
|
The conditional include is so that you can be developing off fec-styles locally and this pulls it in from a local server, rather than having to merge styles in and pull down via npm. And I think vendor styles like datatables that are only going to be used here can just be included here, separate from fec-style. |
|
This works for me. Can you just add a line to the README? |
|
Just caught something. It looks like maybe the datatables styles are being loaded in after fec-styles, because its now overriding several things that it wasn't before. |
|
@noahmanger try re-running |
|
Ooooh, yeah, I was just running them locally because we haven't merged them On Mon, Aug 17, 2015 at 3:47 PM, Joshua Carp notifications@github.com
Noah Manger |
* Document style environment configuration in README * Delete unused imports * Delete unused styles
|
Updated: lots of files deleted, and docs updated. |
|
@noahmanger would we need access to the sass variables from fec-style in the local scss files? Like lets say web app wants to override panel from the style guide but needs the $primary variable? |
|
I guess if you wanted to do that it would be helpful, but I think even then I'd say those changes should live in fec-style. But I could be convinced. |
| @@ -7,8 +7,13 @@ | |||
|
|
|||
| {% include 'partials/meta-tags.html' %} | |||
|
|
|||
| <!-- <link rel="stylesheet" href="/{{ assets['dist/styles/styles.css'] }}" /> --> | |||
| <link rel="stylesheet" href="http://localhost:8080/css/styles.css" /> | |||
| <link rel="stylesheet" href="/{{ assets['dist/styles/styles.css'] }}" /> | |||
There was a problem hiding this comment.
Is this the same thing as line 15?
There was a problem hiding this comment.
No, this is the vendor / custom styles. Lines 12-16 adds fec-style. We can change the names if you want.
There was a problem hiding this comment.
Oh got it. That works for me.
|
I vote for merging this as-is and if we need to figure out a way to share sass variables we can figure it out then. |
Use local styles conditionally.
