Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Populating candidate['office'] with the correct info #50

Merged
merged 2 commits into from
Mar 4, 2015

Conversation

noahmanger
Copy link
Contributor

Grabbing the office title from the candidate's object instead of the primary committee's type.

Won’t work until #444 is merged

@theresaanna
Copy link
Contributor

@noahmanger Travis won't pass until the unit tests pass. If you would like help updating the tests, lmk.

@noahmanger
Copy link
Contributor Author

Shouldn't it pass once @LindsayYoung 's PR on the API side?

@theresaanna
Copy link
Contributor

@noahmanger Unit tests don't call the api. There's mock JSON in openfecwebapp/tests.

@noahmanger
Copy link
Contributor Author

Aaaaah. Then yeah can you show me how to update?

On Tue, Mar 3, 2015 at 9:24 AM, Theresa notifications@github.com wrote:

@noahmanger https://github.com/noahmanger Unit tests don't call the
api. There's mock JSON in openfecwebapp/tests.


Reply to this email directly or view it on GitHub
#50 (comment).

Noah Manger
18F http://18f.gsa.gov | Work: 415-696-6146

@noahmanger
Copy link
Contributor Author

Ping @theresaanna or @LindsayYoung

theresaanna added a commit that referenced this pull request Mar 4, 2015
Populating candidate['office'] with the correct info
@theresaanna theresaanna merged commit 75c0ab2 into master Mar 4, 2015
@theresaanna theresaanna deleted the presidential-label-fix branch March 4, 2015 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants