Feature/filings detail #569
Conversation
|
If we are showing everything can we use the respective report partials we already have? The names are tricky and we already spent a lot of time checking those. |
|
@LindsayYoung we can't use them in their exact form, since we can't mix and match jinja and handlebars templates, but yeah, we can copy over the variable names. But the list of variables we're showing in the mockup doesn't quite match any of the three existing reports templates. @noahmanger, were those variables just placeholders, or are they authoritative? |
As of fecgov/openFEC-web-app#569, data table rows that trigger a detail panel are given the "js-panel-trigger" class. Don't use `cursor: pointer` or other panel-related behaviors for other data table rows. [Resolves 18F#57]
|
Ready for review @noahmanger. Note: this will work slightly better once https://github.com/18F/openFEC/pull/1175, since I harmonized a few variable names there. Working with the panel code reminds me that we should refactor and test it, since it's a little hairy right now, but that can happen in a separate patch, and after launch. |
|
Oops, sorry I meant to merge yesterday. |
|
That's cool, it's better now anyway. |
@noahmanger this needs some work on styles: the filings panel is more or less unstyled, and it wasn't immediately clear how to get the panel to display at the correct size on the committee filings page. We'll also have to to think about differences in variable names between Presidential, House/Senate, and PAC/Party filings, since the variable names from the mockup don't fit all three.
[Resolves #399]
[Resolves #405]