This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Throw 404 instead of 500 on missing detail results. #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app currently throws a 500 when a candidate or committee detail result is not found (e.g., /committee/blah). That's not the semantically correct code: if the requested entity isn't found, we should throw a 404. [Resolves https://github.com/18F/openFEC/issues/724]
LindsayYoung
added a commit
that referenced
this pull request
Sep 3, 2015
Throw 404 instead of 500 on missing detail results.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app currently throws a 500 when a candidate or committee detail
result is not found (e.g., /committee/blah). That's not the semantically
correct code: if the requested entity isn't found, we should throw a
404.
[Resolves https://github.com/18F/openFEC/issues/724]