This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/election lookup styles #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2015 20:23
Useful for accessibility
| <form> | ||
| <div class="search-controls__row"> | ||
| <label class="label" for="cycle-select">Choose an election cycle</label> | ||
| {{ select.cycle_select(cycles, cycle) }} |
There was a problem hiding this comment.
The cycle select widget changes the URL and refreshes the page on change, which we don't want to do here. I'll fix during review.
|
I noticed that one of the javascript unit tests failed, but the Travis build didn't notice. Fixed the test and the Travis issue on merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markup updates for the election lookup to make use of 18F/fec-style#64
There's still a few things on the mockup that need to be implemented, but they're more in the JS so @jmcarp we should talk about these pieces.