Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Use list of election districts from 18F/1179. #593

Merged

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Sep 4, 2015

@jmcarp
Copy link
Contributor Author

jmcarp commented Sep 8, 2015

Now that https://github.com/18F/openFEC/pull/1179 is merged, this is ready for review @noahmanger.

@noahmanger
Copy link
Contributor

This works as expected, except it looks like the district maps still reference the current district boundaries, rather than what they were at the time. Two ways I could see to deal with this:

  1. We simply hide the district maps on election pages for anything before 2012 (the first year of the current districting), or
  2. Get all the past congressional district maps.

Maybe do option 1 for launch and 2 for later?

@jmcarp
Copy link
Contributor Author

jmcarp commented Sep 8, 2015

Right, this patch only touches the links on the candidate district page. Hiding maps for older cycles is probably best for now, but we should dig up older districts maps before too long. Also, zip code search is going to be a pain for older elections.

@noahmanger
Copy link
Contributor

Ugh yeah. Ok, I'll merge this and make a separate issue for hiding maps on older pages.

noahmanger pushed a commit that referenced this pull request Sep 8, 2015
Use list of election districts from 18F/1179.
@noahmanger noahmanger merged commit 3d20859 into fecgov:develop Sep 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants