This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Counting candidates is hard, lets just show the money #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,10 +128,6 @@ <h2 class="icon-heading__title widget__title"><span class="t-short">Find electio | |||
| <h2 class="widget__title"><span class="t-short">So far in the 2016 presidential election:</span></h2> | |||
| <div class="widget__content"> | |||
| <div> | |||
| <h5 class="t-data-header">Candidates running</h5> | |||
| <span class="t-big-data js-count"></span> | |||
There was a problem hiding this comment.
Is the js code that is using js-count still needed elsewhere, or should it also be removed?
There was a problem hiding this comment.
I am not sure. I will take a look again. Thanks Marco!
|
@LindsayYoung did you resolve that question? |
|
I just removed the js references to js-count. Will merge once tests pass. |
noahmanger
pushed a commit
that referenced
this pull request
Sep 22, 2015
Counting candidates is hard, lets just show the money
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We won't have conflicting candidate counts and we still have big numbers for context