This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/update maps #707
Merged
Feature/update maps #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmcarp
commented
Sep 17, 2015
jmcarp
commented
- Build US state topojson from Census data (fixes FIPS code for Minnesota)
- Use the same FIPS data as the API for developer sanity
- Fix a few miscellaneous election map bugs
- Add data provenance notes
Alaska is so large that selecting it would normally trigger a refresh of the state overlays. This patch prevents state redraws triggered internal zooming and panning.
jmcarp
force-pushed
the
feature/update-maps
branch
from
ae76928
to
2a42d9a
Compare
|
Which election map bugs does this fix? Just so I know where to look. |
|
Good call--I've been meaning to institute some standards for documenting issues and pull requests, and the description of this patch wouldn't have made the cut. Fixes:
|
|
Great. Functionally works great. @msecret do you want to review the js? |
|
@msecret do you have time to review? Would like to get this squared away soon if possible. |
|
@noahmanger turns out Marco's OOO for the week. We may want to merge now and ask for a review next week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.