This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Remove incumbent indicator from browse view. #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in fecgov#647, candidate incumbency status is only defined per election, and not across a candidate's electoral history. Since the candidate browse view shows summary information about candidates rather than per-cycle information, it doesn't make sense to show the incumbency indicator here. [Resolves fecgov#647]
noahmanger
pushed a commit
that referenced
this pull request
Sep 18, 2015
Remove incumbent indicator from browse view.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #647, candidate incumbency status is only defined per
election, and not across a candidate's electoral history. Since the
candidate browse view shows summary information about candidates rather
than per-cycle information, it doesn't make sense to show the incumbency
indicator here.
[Resolves #647]