This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Replace existing modal callback with new callback. #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a subtle issue such that each render adds a new modal callback to the table. Instead, on render, remove the previous callback if present before adding the new one.
| @@ -275,7 +276,8 @@ function modalRenderFactory(template, fetch) { | |||
| $modal.appendTo($main); | |||
| $table.find('tr').attr('tabindex', 0); | |||
|
|
|||
| $table.on('click keypress', '.js-panel-toggle tr.' + MODAL_TRIGGER_CLASS, function(e) { | |||
| $table.off('click keypress', '.js-panel-toggle tr.' + MODAL_TRIGGER_CLASS, callback); | |||
| @@ -313,7 +315,8 @@ function modalRenderFactory(template, fetch) { | |||
| }); | |||
| } | |||
| } | |||
| }); | |||
| }; | |||
| $table.on('click keypress', '.js-panel-toggle tr.' + MODAL_TRIGGER_CLASS, callback); | |||
noahmanger
pushed a commit
that referenced
this pull request
Sep 24, 2015
Replace existing modal callback with new callback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a subtle issue such that each render adds a new modal callback to
the table. Instead, on render, remove the previous callback if present
before adding the new one.
Related to #734.