This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Replace empty tables with placeholder text. #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On fetching results from tables without filters, destroy the `DataTable` instance and add placeholder text if no results found. Note: this patch uses a placeholder placeholder, which would probably benefit from style and content review by @noahmanger and @emileighoutlaw. [Resolves fecgov#512]
| if (!response.pagination.count) { | ||
| api.destroy(); | ||
| var $table = $(api.table().node()); | ||
| $table.before('No data found.'); |
There was a problem hiding this comment.
Can we put this in a <div class="message message--alert">?
|
Not all of the tables on the single committee page use the default |
|
Updated! |
noahmanger
pushed a commit
that referenced
this pull request
Sep 25, 2015
Replace empty tables with placeholder text.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On fetching results from tables without filters, destroy the
DataTableinstance and add placeholder text if no results found. Note: this patch
uses a placeholder placeholder, which would probably benefit from style
and content review by @noahmanger and @emileighoutlaw.
[Resolves #512]