Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Update built-in date filters. #781

Merged
merged 1 commit into from
Sep 28, 2015

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Sep 27, 2015

[Resolves #725]

@noahmanger
Copy link
Contributor

Not positive, but I think we want "Last quarter" too. Fine to merge either way.

@@ -5,20 +5,16 @@
<legend for="{{ name }}" class="label">{{ label }}</legend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would change all the date filters, and not just the receipts and disbursements. This filter works well for filings. (If it is too annoying to have both filters now, it can wait until after launch)

@jmcarp
Copy link
Contributor Author

jmcarp commented Sep 27, 2015

@noahmanger: as of #725, looks like we want "last quarter" out, but we may have changed our collective minds in another issue or conversation. @LindsayYoung: has FEC weighed in on which filters are appropriate for filings? Simple enough to use different options for different tables if necessary.

@noahmanger
Copy link
Contributor

Yeah, I feel like this is still an open question because there's some disagreement in the group. They were very firm that we should remove "Today" and "This month" and "This quarter" from the other pages though, so I'm going to merge this now and then we can add in further options as we agree.

Also, obviously, one can set manual date filters to whatever they want.

noahmanger pushed a commit that referenced this pull request Sep 28, 2015
@noahmanger noahmanger merged commit 0bbaf36 into fecgov:develop Sep 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants