This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Newrelic #79
Merged
Newrelic #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,6 +85,7 @@ def currency_filter(num, grouping=True): | |||
| return locale.currency(num, grouping=grouping) | |||
|
|
|||
| if __name__ == '__main__': | |||
| nr_agent.initialize() | |||
There was a problem hiding this comment.
My impression from the docs is that we can either run our app prefixed with newrelic-admin run-program or import and initialize the agent within the app. One or the other should be enough--I don't think we need both.
There was a problem hiding this comment.
Good catch, @jmcarp . Yes, let's standardize on the wrapper script and take this import/initialize out.
| # "development", "test", "staging" or "production". | ||
| # | ||
|
|
||
| [FEC_ENVIRONMENT:development] |
There was a problem hiding this comment.
Should this be NEW_RELIC_ENV?
There was a problem hiding this comment.
Actually that should all be taken care of in the CF manifests, I think... We can probably just take out this part. At least the newrelic.ini that @dlapiduz submitted for the API had monitor_mode set to true globally.
- Set high_security to true - Removed app names (these are specified in CF manifests) - Removed redundant environ-specific settings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got new relic working on the test instance. Still need to up the security settings.