This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Feature/updating filings panel #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2015 14:21
- Adds filer name and link to panel - Adds amendment indicator to panel - Adds pretty datetime handlebars helper
|
This should be good to merge if anyone can review it. |
| @@ -24,8 +25,22 @@ function datetime(value) { | |||
| var parsed = moment(value, 'YYYY-MM-DDTHH:mm:ss'); | |||
| return parsed.isValid() ? parsed.format('MM-DD-YYYY') : null; | |||
| } | |||
|
|
|||
| function prettyDatetime(value) { | |||
There was a problem hiding this comment.
This is a copy and paste of the datetime helper, aside from the format string. How about modifying the existing function to take a format or pretty option:
{{{datetime this.date pretty=true}}}
|
@jmcarp made those changes. Thanks for the suggestions. |
added 2 commits
October 6, 2015 11:46
|
@noahmanger -- Do we want the button on the top to say "View original report"? I feel like we talked about that previously. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing info to filings panels:
Also adds a more readable datetime helper. @emileighoutlaw what do you think about this format for dates in this situation:
Jan 1, 2015? I think it makes sense to stick with01-01-2015format in the columns and in the filters, but if we're just displaying a date in a regular text area, I find the prettier version helpful.Last, makes the pdf link a
target="_blank"to make it consistent with the main url column in the table.Resolves #789 and #778