This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Fix candidate URL on election page. #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmcarp
commented
Oct 15, 2015
jmcarp
commented
- Use URL helper on election page.
- Delete unused code.
* Use URL helper on election page. * Delete unused code.
| @@ -154,7 +153,7 @@ function drawComparison(results) { | |||
| var $comparison = $('#comparison'); | |||
| var context = {selected: results.slice(0, 10), options: results.slice(10)}; | |||
| $comparison.prepend(comparisonTemplate(context)); | |||
| new dropdown.Dropdown($comparison.find('.js-dropdown')); | |||
| new dropdown.Dropdown($comparison.find('.js-dropdown')); | |||
There was a problem hiding this comment.
Do not use 'new' for side effects.
There was a problem hiding this comment.
Can we turn off this warning?
noahmanger
pushed a commit
that referenced
this pull request
Oct 15, 2015
Fix candidate URL on election page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.