This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Updating cycle select placements #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 15, 2015 16:10
And making section heading markup consistent
…/removing-tooltips
|
Ok this is good to go. 18F/fec-style#153 resolves @jenniferthibault 's one piece of design feedback. |
| @@ -6,7 +6,7 @@ | |||
| <div class="container"> | |||
| <div class="section__heading"> | |||
| <h2 class="heading__title" id="section-2-heading"> | |||
| Money received by the <span class="term" data-term="Committee">committee</span> | |||
| Money received by the committee - {{ cycle|fmt_year_range }} | |||
There was a problem hiding this comment.
Just curious--why drop the glossary lookup here? I'm not clear on when we want to wrap terms in glossary lookups and when we don't.
There was a problem hiding this comment.
Good question. I think it makes sense to not make words in headings glossary links. @emileighoutlaw ?
…/removing-tooltips Conflicts: templates/partials/candidate/other-spending-tab.html
|
Conflicts resolved. |
added 2 commits
October 21, 2015 12:28
…/removing-tooltips Conflicts: templates/partials/committee/filings-tab.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #847