Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Feature/big number links #878

Merged
merged 8 commits into from
Oct 22, 2015
Merged

Feature/big number links #878

merged 8 commits into from
Oct 22, 2015

Conversation

LindsayYoung
Copy link
Contributor

Adding links to forms that have the relevant information
for the Presidential and independent expenditure totals.

screen shot 2015-10-22 at 11 27 19 am

We don't show the IE spending on that page anymore, but
There isn't a better way to explain where we get that
number. Not having a link for it might imply that the
presidential link would give the information, which it
doesn't.

We could improve this in the future, when we have a
view for IEs.

resolves #697

for the Presidential and independent expenditure totals.

We don't show the IE spending on that page anymore, but
There isn't a better way to explain where we get that
number. Not having a link for it might imply that the
presidential link would give the information, which it
doesn't.

We could improve this in the future, when we have a
view for IEs.

resolves #697
@jmcarp
Copy link
Contributor

jmcarp commented Oct 22, 2015

LGTM, but we should always use url_for over hard-coded URLs when possible. This wouldn't work on production as-is, since it always points to the dev proxy.

@LindsayYoung
Copy link
Contributor Author

Thanks for catching that! I will update it now!

@jmcarp jmcarp merged commit e54d4ae into develop Oct 22, 2015
@jmcarp jmcarp removed the plz-review label Oct 22, 2015
@LindsayYoung LindsayYoung deleted the feature/big-number-links branch February 9, 2016 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants