This repository has been archived by the owner on Dec 23, 2017. It is now read-only.
Handle multiple null values for state and district. #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following a recent change in the API, missing values for `state` and `district` have mostly changed from `null` to "US" and "00", respectively. This patch checks for all possible missing values upon receiving data from the API. h/t @noahmanger
|
Almost there. Searching by zip code is only returning house races; no senate or president. |
|
Derp. That looks like a distinct issue--investigating. |
|
@noahmanger that second issue should be fixed in https://github.com/18F/openFEC/pull/1292. |
noahmanger
pushed a commit
that referenced
this pull request
Oct 23, 2015
Handle multiple null values for state and district.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a recent change in the API, missing values for
stateanddistricthave mostly changed fromnullto "US" and "00",respectively. This patch checks for all possible missing values upon
receiving data from the API.
To check, verify that searching for elections by zip, state, and district work as expected.
h/t @noahmanger