Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Not properly detecting ccr.gov as a redirect #367

Closed
konklone opened this issue Jan 20, 2016 · 1 comment
Closed

Not properly detecting ccr.gov as a redirect #367

konklone opened this issue Jan 20, 2016 · 1 comment
Assignees
Labels

Comments

@konklone
Copy link
Contributor

It's because http://ccr.gov -> https://ccr.gov, even though https://ccr.gov -> https://www.sam.gov/[...].

We're marking a domain holistically as a "redirect" only if all 4 of its endpoints are either down or redirect externally. If one of the endpoints redirects internally, it's not flagged as a redirect.

This is because we want redirects within the domain, to e.g. /home/whatever, to not result in the domain being considered a redirector.

We can resolve this by marking redirects that change the protocol as different than internal redirects, and allow protocol changes to not disqualify a domain as being marked as a "redirect". This should be doable with minimal changes to the site-inspector 1.x branch.

@konklone konklone added the bug label Jan 20, 2016
@konklone konklone self-assigned this Jan 20, 2016
@konklone
Copy link
Contributor Author

Moving work to cisagov/pshtt#13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant