Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage metrics to unit test suite #1696

Closed
4 tasks done
shawnbot opened this issue Feb 3, 2017 · 2 comments
Closed
4 tasks done

Add code coverage metrics to unit test suite #1696

shawnbot opened this issue Feb 3, 2017 · 2 comments
Assignees

Comments

@shawnbot
Copy link
Contributor

shawnbot commented Feb 3, 2017

Per #1673, we are going to add code coverage metrics as part of our 1.0 release so that we can demonstrate (hopefully) improvement in future releases. To do this, we need to:

  • Ask our friends in Engineering (and Infrastructure) which code coverage tool to use

    • James Seppi mentioned that our Before You Ship guide requires Code Climate for static analysis, but I need to follow up on whether that applies to us
    • Noah Kunin asked that we use Code Climate and said that it "seems to be an emerging standard"

    In summation: we'll use Code Climate.

  • Add that tool to our project

  • Integrate code coverage into our CI setup

  • Maybe: document what code coverage means on the site

@shawnbot
Copy link
Contributor Author

shawnbot commented Feb 8, 2017

This is basically done in #1702. Let's create a new issue to document what code coverage means, and how we deal with it in pull requests and/or releases.

@shawnbot
Copy link
Contributor Author

shawnbot commented Feb 8, 2017

This is done, and I've moved the documentation tasks over to #1704.

@shawnbot shawnbot closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant