Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESC key broken in bootstrap modal popups #26

Closed
quepol opened this issue Mar 19, 2014 · 3 comments
Closed

ESC key broken in bootstrap modal popups #26

quepol opened this issue Mar 19, 2014 · 3 comments
Labels
type:bug

Comments

@quepol
Copy link
Contributor

quepol commented Mar 19, 2014

see branch uglypopups and launch-nolinks -- conflict with slideshow js? @amoose?
@quepol quepol added the bug label Mar 19, 2014
@amoose
Copy link
Contributor

amoose commented Mar 19, 2014

What the problem is?

@polastre
Copy link
Contributor

When the pop up modal opens, the ESC key does not close it (it does work in the bootstrap demos at getbootstrap.com)

amoose added a commit that referenced this issue Mar 19, 2014
@amoose
[Issue #26] Removes onkeydown event listener for slideshow
6cd498f
amoose added a commit that referenced this issue Mar 26, 2014
@amoose
[Issue #26] Resolves ESC key dismissal issue for modal
e3a91ab
NoahKunin added a commit that referenced this issue Apr 7, 2014
@NoahKunin
Merge pull request #37 from 18F/feex_esc_dismissal
0cc4259 
[Issue #26] Resolves ESC key dismissal issue for modal
@quepol
Copy link
Contributor Author

quepol commented Apr 25, 2014

Resolved with those commits. Closing.

@quepol quepol closed this as completed Apr 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amoose @quepol @polastre