Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal text doesn't make sense for our own 18f.tumblr links #29

Closed
aaronsnow opened this issue Mar 19, 2014 · 3 comments
Closed

Modal text doesn't make sense for our own 18f.tumblr links #29

aaronsnow opened this issue Mar 19, 2014 · 3 comments

Comments

@aaronsnow
Copy link
Contributor

We don't "hate to see you go" when they click on our 18f.tumblr blog posts.

image
@polastre
Copy link
Contributor

tumblr is external to gsa.gov and subject to a different privacy policy, so they are going...

@aaronsnow
Copy link
Contributor Author

Even if that's true (pretty sure @NoahKunin, J.D., disagrees), we don't "hate to see [them] go." Can we get rid of that sentence? (Which branch should I pull request against?)

@quepol quepol added the wontfix label Apr 25, 2014
@quepol
Copy link
Contributor

quepol commented Apr 25, 2014

Given that we have a path forward that doesn't include the modal popups, I'm labeling this "wontfix" and closing. Feel free to re-open if you feel strongly. I think the devel branch is the closest to being deployable.

@quepol quepol closed this as completed Apr 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aaronsnow @quepol @polastre